Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena databases #3062

Merged
merged 22 commits into from
Sep 26, 2022
Merged

Athena databases #3062

merged 22 commits into from
Sep 26, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 31, 2022

CatalogName and Database are optional parameters for Athena query execution

Screenshot from 2022-09-02 16-31-14
Screenshot from 2022-09-02 16-31-40
Screenshot from 2022-09-02 16-31-52

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #3062 (8a7a5f7) into master (e29591d) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
- Coverage   35.45%   35.33%   -0.13%     
==========================================
  Files         641      642       +1     
  Lines       28351    28451     +100     
  Branches     4137     4160      +23     
==========================================
  Hits        10053    10053              
- Misses      17125    17224      +99     
- Partials     1173     1174       +1     
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.04% <0.00%> (-0.05%) ⬇️
lambda 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../app/containers/Bucket/Queries/Athena/Database.tsx 0.00% <0.00%> (ø)
...p/containers/Bucket/Queries/Athena/QueryEditor.tsx 0.00% <0.00%> (ø)
...pp/containers/Bucket/Queries/Athena/Workgroups.tsx 0.00% <ø> (ø)
...g/app/containers/Bucket/Queries/requests/athena.ts 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 September 5, 2022 14:11
nl0
nl0 previously approved these changes Sep 6, 2022
@fiskus
Copy link
Member Author

fiskus commented Sep 26, 2022

Merged and fixed conflicts

@fiskus fiskus requested a review from nl0 September 26, 2022 09:44
@fiskus fiskus merged commit cde94d0 into master Sep 26, 2022
@fiskus fiskus deleted the athena-databases branch September 26, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants